-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config option for disabling reporting #354
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucabello
reviewed
Nov 8, 2024
sed-i
force-pushed
the
feature/disable_reporting
branch
from
November 12, 2024 20:10
9e5858e
to
c41f5ca
Compare
This was referenced Nov 13, 2024
Signed-off-by: Leon <[email protected]>
sed-i
force-pushed
the
feature/disable_reporting
branch
from
November 14, 2024 04:57
a2d9e0b
to
4dc761d
Compare
lucabello
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
By default, grafana sends out anonymous usage stats. This may be undesired in hardened environments.
Solution
Add charm config option to disable reporting.
reporting_enabled
(ref), while in grafana-agent there's a cli flag called-disable-reporting
. We want to be consistent across charms, as well as use a positive rather than negative term, for simplicity. So we'll go withreporting_enabled
everywhere.reporting_enabled=true
andreporting_enabled=false
: whentrue
, we do not render any config, so grafana will use default values; when false, we disable both reporting and plugin update checks. This is desirable because:In tandem with:
Fixes #353.
Context
Testing Instructions
Upgrade Notes