Datasource interface tests #361
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PietroPasotti
changed the title
PietroPasotti
changed the title
sed-i
reviewed
Dec 2, 2024
tests/interface/conftest.py
Outdated
There was a problem hiding this comment.
Practically, scenario tests and interface tests are all unit tests.
This PR duplicates the code for the patches we apply.
Can we move all this under unit instead?
There was a problem hiding this comment.
not without one more PR to charm-relation-interfaces, because by default, it's looking for interface tests under tests/interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interface test fixture for the grafana_datasource interface tests.
See: canonical/charm-relation-interfaces#204
to test:
tox -e interface