-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datasource interface tests #361
Open
PietroPasotti
wants to merge
4
commits into
main
Choose a base branch
from
datasource_interface_tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
from contextlib import ExitStack | ||
from unittest.mock import patch | ||
|
||
import pytest | ||
from scenario import State, Container | ||
|
||
from charm import GrafanaCharm | ||
|
||
|
||
@pytest.fixture | ||
def containers(): | ||
"""Mocks for standard containers grafana needs to work.""" | ||
return [ | ||
Container(name="grafana", can_connect=True), | ||
Container(name="litestream", can_connect=True), | ||
] | ||
|
||
|
||
@pytest.fixture(autouse=True, scope="module") | ||
def patches(): | ||
with ExitStack() as stack: | ||
stack.enter_context(patch("charm.GrafanaCharm._push_sqlite_static", new=lambda _: None)) | ||
stack.enter_context(patch("lightkube.core.client.GenericSyncClient")) | ||
stack.enter_context( | ||
patch("socket.getfqdn", new=lambda *args: "grafana-k8s-0.testmodel.svc.cluster.local") | ||
) | ||
stack.enter_context(patch("socket.gethostbyname", new=lambda *args: "1.2.3.4")) | ||
stack.enter_context( | ||
patch.multiple( | ||
"charm.KubernetesComputeResourcesPatch", | ||
_namespace="test-namespace", | ||
_patch=lambda *_a, **_k: True, | ||
is_ready=lambda *_a, **_k: True, | ||
) | ||
) | ||
stack.enter_context(patch.object(GrafanaCharm, "grafana_version", "0.1.0")) | ||
yield | ||
|
||
|
||
@pytest.fixture | ||
def grafana_source_tester(interface_tester, containers): | ||
interface_tester.configure( | ||
charm_type=GrafanaCharm, | ||
state_template=State( | ||
leader=True, | ||
containers=containers, | ||
), | ||
) | ||
yield interface_tester |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
from interface_tester import InterfaceTester | ||
|
||
|
||
def test_grafana_datasource_v0_interface(grafana_source_tester: InterfaceTester): | ||
grafana_source_tester.configure( | ||
interface_name="grafana_datasource", | ||
interface_version=0, | ||
) | ||
grafana_source_tester.run() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Practically, scenario tests and interface tests are all unit tests.
This PR duplicates the code for the patches we apply.
Can we move all this under
unit
instead?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not without one more PR to charm-relation-interfaces, because by default, it's looking for interface tests under tests/interface.