Skip to content

Commit

Permalink
add note regarding forks
Browse files Browse the repository at this point in the history
  • Loading branch information
jdkandersson committed Feb 13, 2023
1 parent 7fa263a commit 316b03c
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,13 @@ exposes our team and Canonical to operational risks.
- PRs can only be merged if all checks pass.
- Bypassing of the rules is disabled.
- Commits must be signed.
- PRs from forks should not be merged directly into the default branch if any of
the CI/CD cannot be run (e.g., because it requires a secret). This is because
there might be issues with the PR that are missed because certain checks did
not run. These PRs should be redirected to a separate branch and then have a
PR raised from that branch to the default branch. The branch protection of a
repo should not allow branches from forks to be merged directly into the
default branch.

The above configuration ensures our team processes around changes are enforced
and provides access to the repository even if some team members are unavailable.
Expand Down

0 comments on commit 316b03c

Please sign in to comment.