fix(allmodels): JIMM does not need to support AllModels #1496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The api was trying to call /version, but our mock didn't implement it.
We now list models via contacting controllers directly.
Removes the support for AllModels() as it is only used in listing,showing,killing or destroying controllers. If in the future we wish to support destroy-controller then we can implement it properly then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the support for AllModels() as it is only used in listing,showing,killing or destroying
controllers. If in the future we wish to support destroy-controller then we can implement it
properly then.
Rather than outright remove it, I've left a comment detailing if we do require this in the future, i.e., when we support bootstrapping, then we can look at this methods.
Engineering checklist
Test instructions