fix(allmodels): JIMM does not need to support AllModels

internal/jujuapi/controller.go

@@ -169,9 +169,11 @@ func (r *controllerRoot) WatchAllModelSummaries(ctx context.Context) (jujuparams
 	}, nil
 }
 
-// AllModels implments the AllModels command on the Controller facade.
+// AllModels is used for list-controllers, show-controller, kill-controller and destroy-controller,
+// we currently do not support this via JIMM. If in the future we do, this method will need implementing.
 func (r *controllerRoot) AllModels(ctx context.Context) (jujuparams.UserModelList, error) {
-	return r.allModels(ctx)
+	const op = errors.Op("jujuapi.AllModels")
+	return jujuparams.UserModelList{}, errors.E(op, errors.CodeNotSupported)
 }
 
 // allModels returns all the models the logged in user has access to.

internal/jujuapi/controller_test.go

@@ -76,25 +76,12 @@ func (s *controllerSuite) TestMongoVersion(c *gc.C) {
 }
 
 func (s *controllerSuite) TestAllModels(c *gc.C) {
-	conn := s.open(c, nil, "bob")
+	conn := s.open(c, nil, "alice")
 	defer conn.Close()
 	client := controllerapi.NewClient(conn)
-
-	models, err := client.AllModels()
-	c.Assert(err, gc.Equals, nil)
-	c.Assert(models, jc.SameContents, []base.UserModel{{
-		Name:           "model-1",
-		UUID:           s.Model.UUID.String,
-		Owner:          "[email protected]",
-		LastConnection: nil,
-		Type:           "iaas",
-	}, {
-		Name:           "model-3",
-		UUID:           s.Model3.UUID.String,
-		Owner:          "[email protected]",
-		LastConnection: nil,
-		Type:           "iaas",
-	}})
+	_, err := client.AllModels()
+	c.Assert(err, gc.ErrorMatches, `not supported \(not supported\)`)
+	c.Assert(jujuparams.IsCodeNotSupported(err), gc.Equals, true)
 }
 
 func (s *controllerSuite) TestModelStatus(c *gc.C) {