-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Calico CNI #469
Add Calico CNI #469
Conversation
ef53326
to
341845b
Compare
0897424
to
fe7bc8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, Ben! I just have a question about the CheckNetwork
function.
5b08693
to
9d313eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'm learning too. thanks @bschimke95
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I particularly like the CIDR getting moved to utils and the added test cases!
0913919
to
1627b72
Compare
Small update after approvals: I moved the deployment of the tigera-operator into its own namespace. We don't want the operator to have access to all resources in
I promise, stuff still works!
|
1627b72
to
32308f1
Compare
Adds the Calico helm chart and feature implementation. The current implementation of Gateway, Ingress and LB depend on Cilium, hence they are swapped out by a fake implementation for now.
CIDR assignment works as expected: