Fix comments, add commonality between rocks in this repo

canonical · Feb 16, 2024 · 1b8a96d · 1b8a96d
1 parent fc2f494
commit 1b8a96d
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 2 deletions.
diff --git a/pmmlserver/dummy_pyproject.toml b/pmmlserver/dummy_pyproject.toml
@@ -7,4 +7,5 @@ authors = ["none"]
 [tool.poetry.dependencies]
 python = ">=3.8,<3.12"
 kserve = { path = "../python/kserve", develop = false }
-pmmlserver = { path = "../python/pmmlserver", develop = false }
+sklearnserver = { path = "../python/sklearnserver", develop = false }
+
diff --git a/pmmlserver/rockcraft.yaml b/pmmlserver/rockcraft.yaml
@@ -1,4 +1,4 @@
-# Based on https://github.com/kserve/kserve/blob/release-0.11/python/paddle.Dockerfile
+# Based on https://github.com/kserve/kserve/blob/release-0.11/python/pmml.Dockerfile
 name: pmmlserver
 summary: Pmml server for Kserve deployments
 description: "Kserve Pmml server"
@@ -80,3 +80,4 @@ parts:
     source-tag: v0.11.0
     override-build: |
       cp -fr third_party/* ${CRAFT_PART_INSTALL}/third_party
+
diff --git a/pmmlserver/tests/test_rock.py b/pmmlserver/tests/test_rock.py
@@ -63,3 +63,16 @@ def test_rock(rock_test_env):
         ],
         check=True,
     )
+    subprocess.run(
+        [
+            "docker",
+            "run",
+            "--entrypoint",
+            "/bin/bash",
+            LOCAL_ROCK_IMAGE,
+            "-c",
+            "ls -la /third_party",
+        ],
+        check=True,
+    )
+