Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add xgboost server rock and tests #45

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Conversation

ca-scribner
Copy link
Contributor

Closes #26.

Testing instructions:

See xgboost/readme.md

Copy link
Contributor

@orfeas-k orfeas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. I left two small comments.

Btw, the only difference in response I noticed when testing is

-  "model_version": "v1.0.0",
+  "model_version": null,
+  "parameters": null,

We 've seen this happen in other places where we use ROCKs like canonical/seldonio-rocks#71 and I 'm still wondering why, but yeah it's not a blocker. I just thought of mentioning it.

xgbserver/rockcraft.yaml Show resolved Hide resolved
xgbserver/rockcraft.yaml Show resolved Hide resolved
@orfeas-k
Copy link
Contributor

orfeas-k commented Mar 7, 2024

Also, it would be nice if we had the testing instructions automated as sanity tests.

@ca-scribner
Copy link
Contributor Author

@orfeas-k agreed about the testing instructions. I actually looked into it, but didn't find a simple way so I dropped it for now. The thing I was hung up on was trying to do it from tox, and I wasn't sure how to docker run the thing and then curl at it. But it would help a lot if they were automated - I just added #47 to capture this

Copy link
Contributor

@orfeas-k orfeas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @ca-scribner

@ca-scribner ca-scribner merged commit d1246b8 into main Mar 7, 2024
7 checks passed
@ca-scribner ca-scribner deleted the KF-5350-add-xgbserver branch March 7, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a ROCK for xgbserver v0.11.2
2 participants