-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add xgboost server rock and tests #45
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good. I left two small comments.
Btw, the only difference in response I noticed when testing is
- "model_version": "v1.0.0",
+ "model_version": null,
+ "parameters": null,
We 've seen this happen in other places where we use ROCKs like canonical/seldonio-rocks#71 and I 'm still wondering why, but yeah it's not a blocker. I just thought of mentioning it.
Also, it would be nice if we had the |
@orfeas-k agreed about the testing instructions. I actually looked into it, but didn't find a simple way so I dropped it for now. The thing I was hung up on was trying to do it from tox, and I wasn't sure how to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @ca-scribner
Closes #26.
Testing instructions:
See xgboost/readme.md