github: run system-tests on larger runners (8cores+32G) #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simondeziel
requested review from
tomponline,
masnax,
roosterfish and
markylaing
as code owners
roosterfish
reviewed
Jun 27, 2024
simondeziel
force-pushed
the
large-runners
branch
3 times, most recently
from
c6793a0
to
23ea8c1
Compare
simondeziel
force-pushed
the
large-runners
branch
from
a172d47
to
b69461a
Compare
|
Things are way more flaky on 24.04 it seems. The wrong/unexpected disk is often picked causing multiple failures. I'm a bit unsure how to improve that so if anyone has an idea, please let me know. |
|
A new failure reason: |
simondeziel
force-pushed
the
large-runners
branch
2 times, most recently
from
eb06085
to
710531c
Compare
Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Max Asnaashari <[email protected]> Signed-off-by: Simon Deziel <[email protected]>
Ceph encryption will need this. Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
This will be a requirement for Ceph encryption as it needs the `dm_crypt` module that's not enabled in 22.04's -kvm kernel. Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
This also avoids any failure during the `setup` phase to trigger the cleanup which runs: ``` + lxc list --all-projects ... + lxc exec micro01 -- lxc list Installing LXD snap, please be patient. If this is your first time running LXD on this machine, you should also run: lxd init To start your first container, try: lxc launch ubuntu:22.04 Or for a virtual machine: lxc launch ubuntu:22.04 --vm +------+-------+------+------+------+-----------+ | NAME | STATE | IPV4 | IPV6 | TYPE | SNAPSHOTS | +------+-------+------+------+------+-----------+ ``` Signed-off-by: Simon Deziel <[email protected]>
…ud-init slowness) Signed-off-by: Simon Deziel <[email protected]>
…m_microceph() Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
Even Go 1.21 has improved support for it since 1.21.11 (golang/go#62278) Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
simondeziel
force-pushed
the
large-runners
branch
from
710531c
to
e642f3e
Compare
masnax
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite the additional HW resources, the test run-times didn't improved drastically but hopefully this should be more robust. This should also open the door to doing heavier tests without running into space or RAM limits. The CPU overcommit ratio is also better thus reducing the steal time.
Test run-times can be compared with https://github.com/canonical/microcloud/actions/runs/9783672548/job/27012801592
Note: the System (1.22.x, interactive) still takes ~3 hours and sometimes fail, same as with the regular runners :/