cmd/microcloud: Force disk ordering by path name #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masnax
requested review from
tomponline,
roosterfish and
markylaing
as code owners
masnax
force-pushed
the
sort-disks
branch
5 times, most recently
from
002e74d
to
a18779b
Compare
|
This is blocked by #342 |
Signed-off-by: Max Asnaashari <[email protected]>
Signed-off-by: Max Asnaashari <[email protected]>
|
@roosterfish mind taking a look at this one? Should fix some inconsistencies in the test suite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #332 too but since #334 is having issues with 24.04 VMs, I think it's worth merging now.
This makes it so that when disks are loaded for selection either internally during preseed/auto, or visually in a table with interactive setup, that they are sorted by their path, rather than the order that they appear in the list of resources fetched from LXD.