Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DPE-2731] Secret labels + missing unittests #268

Closed
wants to merge 5 commits into from
Closed

[DPE-2731] Secret labels + missing unittests #268

wants to merge 5 commits into from

Conversation

juditnovak
Copy link
Contributor

@juditnovak juditnovak commented Oct 12, 2023 •
edited
Loading

Issue

Secrets not using labels (and have prototype code)

Furthemore: a good 200 lines of unittests were missing!!!!!!!!!!!!!!!!!!!!!!!!

Solution

Adding the same refactor + Secret Labels usage as in the equal MongoDB K8s PR

Adding the missing unittests from MongoDB K8s charm

NOTE: 'Libraries out of sync' label will be removed when Dmitryj is merging External Secrets

@juditnovak juditnovak force-pushed the DPE-2731_secret_labels branch from 5d8fc32 to 45d936f Compare October 12, 2023 20:00
@juditnovak juditnovak marked this pull request as ready for review October 13, 2023 07:13
@MiaAltieri
Copy link
Contributor

I thought we decommission main - can you make this PR for both 6/edge and 5/edge

MiaAltieri
MiaAltieri requested changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@MiaAltieri MiaAltieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update target branch

This was referenced Oct 13, 2023
Merged
Merged
juditnovak added a commit that referenced this pull request Oct 16, 2023
@juditnovak
[DPE-2731] Secret labels (5edge) (#269)
c26e7ce 
## Issue

More details on the original PR:
#268

## Solution
@juditnovak
Copy link
Contributor Author

The contents of this PR were already added in the two PRs referenced above. Closing

@juditnovak juditnovak closed this Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiaAltieri MiaAltieri MiaAltieri requested changes

@dmitry-ratushnyy dmitry-ratushnyy dmitry-ratushnyy approved these changes

@delgod delgod delgod approved these changes

Assignees
No one assigned
Labels
Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@juditnovak @MiaAltieri @delgod @dmitry-ratushnyy