[DPE-3293] mongos charm supports external connections via data-integrator charm #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiaAltieri
commented
Feb 19, 2024
MiaAltieri
force-pushed
the
external-connections
branch
from
39bced9 to
0670225
Compare
MiaAltieri
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 6/edge #19 +/- ##
==========================================
+ Coverage 78.85% 83.16% +4.30%
==========================================
Files 3 3
Lines 279 291 +12
==========================================
+ Hits 220 242 +22
+ Misses 59 49 -10 ☔ View full report in Codecov by Sentry. |
MiaAltieri
force-pushed
the
external-connections
branch
from
a00e314 to
0ec89b0
Compare
MiaAltieri
force-pushed
the
external-connections
branch
from
0ec89b0 to
5a752ee
Compare
MiaAltieri
force-pushed
the
external-connections
branch
from
9c197d8 to
0da5da1
Compare
MiaAltieri
force-pushed
the
external-connections
branch
from
0da5da1 to
0f34275
Compare
juditnovak
reviewed
Feb 20, 2024
Co-authored-by: Mehdi Bendriss <[email protected]>
MiaAltieri
force-pushed
the
external-connections
branch
from
2db1e06 to
eb8489e
Compare
dragomirp
approved these changes
Feb 23, 2024
Mehdi-Bendriss
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't panic
Changes look big - but there were a lot of files to copy / move - reviewable changes are a little more than 300 lines of diff :)
Problem
Charm doesnt support external connections
Solution
Support external connections when integrated to data-integrator charm
External tests failing
Until data-integrator charm is published these tests will fail