Minor changes to address review comments

canonical · Jun 24, 2024 · 09c8e0b · 09c8e0b
1 parent 311fc67
commit 09c8e0b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/ui/src/app/certificate_requests/row.tsx b/ui/src/app/certificate_requests/row.tsx
@@ -72,8 +72,8 @@ export default function Row({ id, csr, certificate, ActionMenuExpanded, setActio
                         <p><b>Country</b>: {csrObj.country || "N/A"}</p>
                         <p><b>Locality</b>: {csrObj.locality || "N/A"}</p>
                         <p><b>Email Address</b>: {csrObj.emailAddress || "N/A"}</p>
-                        <p><b>Subject Alternative Name DNS</b>: {(csrObj.sansDns && csrObj.sansDns.length > 0) ? csrObj.sansDns.join(', ') : "N/A"}</p>
-                        <p><b>Subject Alternative Name IP addresses</b>: {(csrObj.sansIp && csrObj.sansIp.length > 0) ? csrObj.sansIp.join(', ') : "N/A"}</p>
+                        <p><b>Subject Alternative Name DNS</b>: {csrObj.sansDns && csrObj.sansDns.length > 0 ? csrObj.sansDns.join(', ') : "N/A"}</p>
+                        <p><b>Subject Alternative Name IP addresses</b>: {csrObj.sansIp && csrObj.sansIp.length > 0 ? csrObj.sansIp.join(', ') : "N/A"}</p>
                         <p><b>Certificate request for a certificate authority</b>: {csrObj.is_ca ? "Yes" : "No"}</p>
                     </div>
                 </div>

diff --git a/ui/src/app/nav.tsx b/ui/src/app/nav.tsx
@@ -18,11 +18,7 @@ function SubmitCSR({ csrText, onClickFunc }: { csrText: string, onClickFunc: any
         extractCSR(csrText.trim())
         csrIsValid = true
     }
-    catch (e) {
-        if (e instanceof Error) {
-            console.log(e.message)
-        }
-    }
+    catch { }
 
     const validationComponent = csrText == "" ? <></> : csrIsValid ? <div><i className="p-icon--success"></i>Valid CSR</div> : <div><i className="p-icon--error"></i>Invalid CSR</div>
     const buttonComponent = csrIsValid ? <button className="p-button--positive u-float-right" name="submit" onClick={onClickFunc} >Submit</button> : <button className="p-button--positive u-float-right" name="submit" disabled={true} onClick={onClickFunc} >Submit</button>