-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add nextjs skeleton for the ui #11
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gruyaume
requested changes
Apr 26, 2024
kayra1
force-pushed
the
TLSENG-226-frontend-skeleton
branch
from
April 26, 2024 13:21
366a448
to
faf40e8
Compare
ghislainbourgeois
approved these changes
Apr 26, 2024
saltiyazan
reviewed
Apr 29, 2024
gruyaume
reviewed
Apr 29, 2024
gruyaume
requested changes
Apr 30, 2024
kayra1
force-pushed
the
TLSENG-226-frontend-skeleton
branch
from
April 30, 2024 13:07
ace13cd
to
429deb9
Compare
kayra1
force-pushed
the
TLSENG-226-frontend-skeleton
branch
from
May 9, 2024 11:00
8b76948
to
d8bcc0b
Compare
gruyaume
requested changes
May 10, 2024
Co-authored-by: Guillaume Belanger <[email protected]>
gruyaume
approved these changes
May 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Main UI Code
This is a nextjs UI skeleton which is served by the gocert application located in the UI folder. Simply do:
bun i
/npm i
and
bun run build
/npm run build
to produce an
out/
folder that contains the static assets for the frontend. This directory is then served up.CI for the frontend
On top of the usual CI, there is now a step to build the website to make sure that the rock will build without issue, and there is another step to run the component tests for the nextjs application.
Build
Building uses the mechanism nextjs provides. There is first class IDE support for this option.
Testing
The nextjs app is tested using vitest, which does component level tests. Each test output reports directly to github actions, giving embedded test response messages:
The ROCK
The ROCK now has an extra step to build the UI from within gocert in the build step, and go's installer will copy over the necessary assets.
Checklist: