feat: Frontend basic #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayra1
force-pushed
the
TLSENG-50-frontend
branch
from
e5c54bc
to
b025a4a
Compare
gruyaume
requested changes
Jun 3, 2024
kayra1
requested review from
gruyaume,
DanielArndt,
ghislainbourgeois and
saltiyazan
gruyaume
reviewed
Jun 4, 2024
Co-authored-by: Guillaume Belanger <[email protected]>
gruyaume
requested changes
Jun 4, 2024
|
I've opened new tickets splitting the remaining work down into reviewable chunks, TLSENG 263-264-265-266-267 and added specific details there |
gruyaume
reviewed
Jun 5, 2024
Co-authored-by: Guillaume Belanger <[email protected]>
|
@gruyaume I've rerequested your review, I think you had some good points in your approval and I've addressed them. |
kayra1
force-pushed
the
TLSENG-50-frontend
branch
from
be62c8f
to
0c1ef65
Compare
gruyaume
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change introduces the frontend's basic structure, including the styling, components and internal button state management, and very fundamental tests.
Final Version:
This was defined by a spec written by me in TE067 and approved by @ghislainbourgeois, @saltiyazan and @gruyaume.
I've taken the liberty to split this task into multiple subtasks:
First, the frontend without any complex query functionality to the backend (and minimal amounts of unit tests). This is that PR. This is to help us in coming to an understanding as to what GoCert should look like exactly, and provide a good spot to include the design team in the process.
Second, the query functionality that will allow the frontend to load the backend. This constitutes as version 0.1 of GoCert, aiming to be feature complete in the frontend, which means implementing all of the functionality defined in TE034 written by @gruyaume. There will also be some unit tests that ensure that the correct queries are being made on the correct button presses.
Third, extensive unit tests and integration tests should be introduced to catch any potential regressions that may occur when developing the frontend. I've split this into its own task because testing in React can be its own beast, and produce a lot of lines of code, which may become tedious to review properly.
Checklist: