Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Reject & Delete CSR #23

Merged
merged 16 commits into from
Jun 25, 2024
Merged

feat: Reject & Delete CSR #23

merged 16 commits into from
Jun 25, 2024

Conversation

kayra1
Copy link
Contributor

@kayra1 kayra1 commented Jun 14, 2024 •
edited
Loading

Description

This change allows users to reject or delete CSR's by utilizing the two buttons within the action menu. There is a modal popup for each button that asks the user to confirm the action.

Screenshot from 2024-06-21 16-27-01

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@kayra1 kayra1 marked this pull request as ready for review June 14, 2024 07:36
@kayra1 kayra1 requested a review from a team as a code owner June 14, 2024 07:36
@kayra1 kayra1 marked this pull request as draft June 14, 2024 13:11
@kayra1 kayra1 marked this pull request as ready for review June 21, 2024 08:51
@kayra1 kayra1 marked this pull request as draft June 21, 2024 08:54
@kayra1 kayra1 marked this pull request as ready for review June 21, 2024 13:27
gruyaume
gruyaume requested changes Jun 21, 2024
View reviewed changes
ui/src/app/queries.ts Show resolved Hide resolved
ui/src/app/certificate_requests/row.test.tsx Outdated Show resolved Hide resolved
ui/src/app/certificate_requests/row.tsx Outdated Show resolved Hide resolved
ui/src/app/certificate_requests/row.tsx Outdated Show resolved Hide resolved
@kayra1
Copy link
Contributor Author

kayra1 commented Jun 21, 2024

also the reject button is disabled now for csrs that were already rejected

@kayra1 kayra1 requested a review from gruyaume June 21, 2024 17:32
@kayra1 kayra1 mentioned this pull request Jun 24, 2024
Merged
6 tasks
@kayra1 kayra1 merged commit 5cea721 into main Jun 25, 2024
11 checks passed
@kayra1 kayra1 deleted the TLSENG-266-reject-delete-csr branch June 25, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gruyaume gruyaume gruyaume approved these changes

@saltiyazan saltiyazan saltiyazan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kayra1 @gruyaume @saltiyazan