-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Extract certificate details #35
Conversation
Improves the code to extract certificates Improves the code to compare certificates Display certificate details
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like how it looks. I especially like that if the common name is very long the certificate details wrap.
There are still some suggestions though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can pass on the highlighting for now.
Description
Both certificate and csr details are displayed, as there is no guarantee that those are equal.
Discrepancies between csr and cert fields are highlighted in red.
The details are responsive and they go into one column on small screens.
The expiry date is coloured green, it turns red when we are within one day into expiry and beyond.
Checklist: