Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adds login endpoint and handlers #40

Merged
merged 8 commits into from
Jul 9, 2024
Merged

feat: Adds login endpoint and handlers #40

merged 8 commits into from
Jul 9, 2024

Conversation

saltiyazan
Copy link
Contributor

Description

  • Adds login endpoint and handlers
  • Adds test cases
  • Generates a new jwt secret on server restarts

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@saltiyazan saltiyazan requested a review from a team as a code owner July 4, 2024 15:26
kayra1
kayra1 requested changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@kayra1 kayra1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start

internal/api/handlers.go Outdated Show resolved Hide resolved
internal/api/handlers.go Show resolved Hide resolved
internal/certdb/certdb.go Show resolved Hide resolved
internal/certdb/certdb.go Show resolved Hide resolved
kayra1
kayra1 reviewed Jul 5, 2024
View reviewed changes
internal/api/handlers.go Outdated Show resolved Hide resolved
kayra1
kayra1 reviewed Jul 5, 2024
View reviewed changes
internal/api/handlers.go Outdated Show resolved Hide resolved
kayra1
kayra1 reviewed Jul 5, 2024
View reviewed changes
internal/api/handlers.go Outdated Show resolved Hide resolved
@saltiyazan saltiyazan requested a review from kayra1 July 5, 2024 10:32
kayra1
kayra1 requested changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@kayra1 kayra1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost done

internal/certdb/certdb.go Show resolved Hide resolved
internal/api/handlers.go Outdated Show resolved Hide resolved
@saltiyazan saltiyazan requested a review from kayra1 July 5, 2024 12:55
kayra1
kayra1 reviewed Jul 5, 2024
View reviewed changes
internal/api/handlers.go Outdated Show resolved Hide resolved
kayra1
kayra1 reviewed Jul 5, 2024
View reviewed changes
internal/api/handlers.go Outdated Show resolved Hide resolved
@saltiyazan saltiyazan requested a review from kayra1 July 8, 2024 07:04
kayra1
kayra1 approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@kayra1 kayra1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one last nit

internal/api/handlers.go Outdated Show resolved Hide resolved
kayra1
kayra1 requested changes Jul 8, 2024
View reviewed changes
internal/api/handlers_test.go Outdated Show resolved Hide resolved
@saltiyazan saltiyazan requested a review from kayra1 July 8, 2024 10:24
kayra1
kayra1 approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@kayra1 kayra1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job

@saltiyazan saltiyazan merged commit 1d221b2 into main Jul 9, 2024
11 checks passed
@saltiyazan saltiyazan deleted the TLSENG-288 branch July 9, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayra1 kayra1 kayra1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saltiyazan @kayra1