Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: users table #48

Merged
merged 12 commits into from
Aug 1, 2024
Merged

feat: users table #48

merged 12 commits into from
Aug 1, 2024

Conversation

kayra1
Copy link
Contributor

@kayra1 kayra1 commented Jul 25, 2024

Description

This change adds the user table and the accompanying aside form to add a new user to GoCert. The tab is only visible to an Admin user, and a regular user will only see the certificate requests table.

image

image

image

image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@kayra1 kayra1 changed the title feat: Users table feat: users table Jul 26, 2024
@kayra1 kayra1 force-pushed the users-table branch 3 times, most recently from ae5db33 to 3a97d2a Compare July 29, 2024 07:26
@kayra1 kayra1 marked this pull request as ready for review July 29, 2024 14:28
@kayra1 kayra1 requested a review from a team as a code owner July 29, 2024 14:28
Copy link
Member

@DanielArndt DanielArndt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the first typescript I've looked at in years, so take my approval with a grain of salt...

ui/src/app/users/asideForm.tsx Outdated Show resolved Hide resolved
@DanielArndt DanielArndt requested a review from a team July 30, 2024 16:02
ui/src/app/users/asideForm.tsx Outdated Show resolved Hide resolved
ui/src/app/users/asideForm.tsx Outdated Show resolved Hide resolved
ui/src/app/aside.tsx Outdated Show resolved Hide resolved
ui/src/app/users/table.tsx Outdated Show resolved Hide resolved
@kayra1 kayra1 requested a review from gruyaume July 31, 2024 09:33
ui/src/app/users/components.tsx Show resolved Hide resolved
ui/src/app/users/table.tsx Outdated Show resolved Hide resolved
@kayra1 kayra1 requested a review from gruyaume August 1, 2024 11:28
ui/src/app/nav.tsx Outdated Show resolved Hide resolved
@kayra1 kayra1 requested a review from gruyaume August 1, 2024 16:32
@kayra1 kayra1 merged commit 8c3383f into main Aug 1, 2024
11 checks passed
@kayra1 kayra1 deleted the users-table branch August 1, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants