Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: accept bundles instead of just certificates #60

Merged
merged 13 commits into from
Aug 27, 2024
Merged

feat!: accept bundles instead of just certificates #60

merged 13 commits into from
Aug 27, 2024

Conversation

kayra1
Copy link
Contributor

@kayra1 kayra1 commented Aug 22, 2024

Description

This PR adds the change required to accept and distribute issuer certificates alongside the certificate of the CSR. A new certificate must contain a bundle of at least 2 certificates in a valid chain to be accepted. Any extra characters will be ignored.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@kayra1 kayra1 marked this pull request as ready for review August 23, 2024 11:15
@kayra1 kayra1 requested a review from a team as a code owner August 23, 2024 11:15
internal/certdb/validation.go Outdated Show resolved Hide resolved
internal/certdb/validation.go Outdated Show resolved Hide resolved
internal/api/handlers_test.go Outdated Show resolved Hide resolved
@kayra1 kayra1 merged commit 6b3aaba into main Aug 27, 2024
11 checks passed
@kayra1 kayra1 deleted the ca branch August 27, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants