Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: log to stdout #63

Merged
merged 2 commits into from
Aug 27, 2024
Merged

fix: log to stdout #63

merged 2 commits into from
Aug 27, 2024

Conversation

kayra1
Copy link
Contributor

@kayra1 kayra1 commented Aug 26, 2024

Description

Logging to stderr does not show up in pebble. This change makes Gocert log to stdout. Probably fixes #56

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@kayra1 kayra1 requested a review from a team as a code owner August 26, 2024 10:42
@kayra1 kayra1 merged commit f4417ae into main Aug 27, 2024
11 checks passed
@kayra1 kayra1 deleted the log-fix branch August 27, 2024 12:01
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gruyaume gruyaume gruyaume approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The logs aren't clear when gocert fails to launch
2 participants
@kayra1 @gruyaume