Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a snap for notary #67

Merged
merged 3 commits into from
Sep 9, 2024
Merged

feat: add a snap for notary #67

merged 3 commits into from
Sep 9, 2024

Conversation

gruyaume
Copy link
Collaborator

@gruyaume gruyaume commented Sep 6, 2024

Description

Notary will not only be used in the Juju ecosystem and having a snap for it will help make notary accessible to more users. This will also be necessary for the (potential) follow-up HSM story.

This PR depends on:

  • chore: change name to notary #65 being merged first
  • The snap name being registered. It is now pending review because notary is a reserved name. Reference here.
  • Add workflow to build and publish snap
  • Add snapcraft credentials to secrets

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gruyaume gruyaume marked this pull request as ready for review September 9, 2024 11:31
@gruyaume gruyaume requested a review from a team as a code owner September 9, 2024 11:31
@gruyaume gruyaume merged commit 6674262 into main Sep 9, 2024
14 checks passed
@gruyaume gruyaume deleted the dev-snap branch September 9, 2024 12:24
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants