Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: inherit secrets in publish-snap workflow #69

Merged
merged 1 commit into from
Sep 9, 2024
Merged

fix: inherit secrets in publish-snap workflow #69

merged 1 commit into from
Sep 9, 2024

Conversation

gruyaume
Copy link
Collaborator

@gruyaume gruyaume commented Sep 9, 2024

Description

Publishing to the snap store fails right now and this PR "should" fix this issue.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gruyaume gruyaume requested a review from a team as a code owner September 9, 2024 14:00
@gruyaume gruyaume merged commit 228ac1d into main Sep 9, 2024
13 checks passed
@gruyaume gruyaume deleted the dev-publish-bug branch September 9, 2024 15:10
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghislainbourgeois ghislainbourgeois ghislainbourgeois approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gruyaume @ghislainbourgeois