Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: generalise database management #70

Merged
merged 5 commits into from
Sep 9, 2024
Merged

chore: generalise database management #70

merged 5 commits into from
Sep 9, 2024

Conversation

gruyaume
Copy link
Collaborator

@gruyaume gruyaume commented Sep 9, 2024

Description

This PR does a couple of things related to the database. Those are mainly because the database is no only used for certificate management anymore, it also stores users and soon Certificate Authority content.

  • Rename the file from certdb to db
  • Treat the certificateRequest and users table in the same way. Both are now un-parametrized and variables are used to referenced to both table names.
  • Rename CertificateRequestsRepository to Database to reflect that the db contains varying types of data.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gruyaume gruyaume requested a review from a team as a code owner September 9, 2024 16:48
@gruyaume gruyaume marked this pull request as draft September 9, 2024 16:49
@gruyaume gruyaume marked this pull request as ready for review September 9, 2024 17:30
internal/db/db_test.go Outdated Show resolved Hide resolved
Co-authored-by: Ghislain Bourgeois <[email protected]>
@gruyaume gruyaume merged commit 4cbd546 into main Sep 9, 2024
13 checks passed
@gruyaume gruyaume deleted the dev-db branch September 9, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants