Add 'deprecated' field for depreacted section generation in image docs #203
Conversation
linostar
force-pushed
the
ROCKS-1224/support-deprecated-channels-tags
branch
from
e1cc71f
to
d74e760
Compare
| @@ -269,6 +271,11 @@ def build_releases_data( | |||
| "until": eol.strftime("%m/%Y") | |||
| } | |||
|
|
|||
| if eol > datetime.now(timezone.utc): | |||
There was a problem hiding this comment.
why don't use datetime.UTC? https://docs.python.org/3/library/datetime.html#datetime.UTC
| v["end-of-life"] for v in builds[img_number]["release"].values() | ||
| ), "%Y-%m-%dT%H:%M:%SZ").replace(tzinfo=timezone.utc) | ||
| if min_eol < datetime.now(timezone.utc): |
There was a problem hiding this comment.
FYI these dates are ISO formatted, so you should be able to compare them as strings
| v["end-of-life"] for v in builds[img_number]["release"].values() | ||
| ), "%Y-%m-%dT%H:%M:%SZ").replace(tzinfo=timezone.utc) | ||
| if min_eol < datetime.now(timezone.utc): | ||
| print("Track skipped because it reached its end of life") |
There was a problem hiding this comment.
Isn't this too late? I.e. the name and path are set before this, which means that even if there's no release, the image will still be built and tested right? But do we want that?
|
One or more files in this PR are not valid! 😬 See logs. |
linostar
force-pushed
the
ROCKS-1224/support-deprecated-channels-tags
branch
from
589eb2e
to
22b17eb
Compare
|
Closing this in favor of #286, because it is much easier than cherry-picking all required commits from main, and the PR validator workflow prevents merging this with main branch which has had multiple changes to oci image.yaml files since this PR was created. Will continue to address the review comments in the new PR. |
Ping the @canonical/rocks team.
Description
The documentation generator for rocks is missing some parts necessary to generate the
Deprecated channels & tagssection.This PR provides the necessary values so that the generator can identify the deperacted tags and list them accordingly, using the expired end-of-life value of each track to determine whether it is depreacted or not.
Related issues
OCI-Factory builds won't work if one image's track has an expired EOL value. Another PR to fix that issue will be out soon.