Do not build/release/test/scan tracks with expired end-of-life values #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linostar
force-pushed
the
ROCKS-973/allow-expired-eol-values
branch
from
6114513
to
1bfff8a
Compare
linostar
force-pushed
the
ROCKS-973/allow-expired-eol-values
branch
from
84edd22
to
e0ea1d5
Compare
linostar
force-pushed
the
ROCKS-973/allow-expired-eol-values
branch
from
c96ef39
to
909dbcb
Compare
linostar
force-pushed
the
ROCKS-973/allow-expired-eol-values
branch
from
909dbcb
to
26a4849
Compare
2 tasks
linostar
changed the title
linostar
changed the title
2 tasks
|
check the conflict pls |
Fixed. |
SamirPS
reviewed
Sep 17, 2024
cjdcordeiro
approved these changes
Sep 30, 2024
|
One or more files in this PR are not valid! 😬 See logs. |
linostar
added a commit
that referenced
this pull request
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ping the @canonical/rocks team.
Description
We want to display deprecated image information in upstream container registries, but in order to that we have to allow deprecated image data to exist in our
image.yamlfiles. The Pydantic validator currently throws an exception whenever an image track has an expired end-of-life value. This PR changes that behavior so that expired end-of-life values are allowed, but tracks with such values are not triggered for testing, building, releasing or vulnerability scanning.Related issues
Picture of a cool rock: