Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error types #72

Merged
merged 13 commits into from
Oct 26, 2023
Merged

Error types #72

merged 13 commits into from
Oct 26, 2023

Conversation

PietroPasotti
Copy link
Collaborator

@PietroPasotti PietroPasotti commented Oct 20, 2023

This pr fixes a number of error types in mocking.py that differed from the ones raised by ops.

Additionally:

With this, Scenario proper is now feature-complete: all hook tools are mockable.

Copy link
Collaborator

@benhoyt benhoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, unfortunately I don't have time to properly review this before Riga. I just scanned through and suggested a couple of nits. Feel free to ping me after Riga if you want more thorough review, otherwise optimistic merge. :-)

scenario/consistency_checker.py Outdated Show resolved Hide resolved
scenario/state.py Outdated Show resolved Hide resolved
scenario/state.py Outdated Show resolved Hide resolved
scenario/mocking.py Outdated Show resolved Hide resolved
@PietroPasotti PietroPasotti merged commit bcbff6a into main Oct 26, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reemit deferred relation event is broken
3 participants