daemon: FakeCommand usage requires reaper.Start() #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benhoyt
approved these changes
Jun 27, 2023
anpep
approved these changes
Jun 27, 2023
|
This PR is mostly theoretical, but aligns with the work done here #249 |
jnsgruk
approved these changes
Aug 1, 2023
flotter
force-pushed
the
testutil-reaper-start
branch
from
354c83c
to
12f56f0
Compare
The usage of testutil.FakeCommand requires the test environment to start and stop the reaper in the case where the reaper option is enabled. For example, in internals/daemon/daemon_test.go: : cmd := testutil.FakeCommand(c, "shutdown", "", true) : However, in daemon_test.go, the code is currently relying on the service manager, provided by the overlord, to start the reaper. This is not a safe solution as not all test implementations may actually run the real overlord code, and even if they do, we have a potential race condition. daemon.Init() -> overlord.New() -> servstate.NewManager() -> reaper.Start() The following changes are introduced: - Add reaper.Start() and reaper.Stop() to the daemon test setup and teardown. - Add a reaper based test for testutil.FakeCommand().
flotter
force-pushed
the
testutil-reaper-start
branch
from
12f56f0
to
374389a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The usage of testutil.FakeCommand requires the test environment to start and stop the reaper in the case where the reaper option is enabled.
For example, in internals/daemon/daemon_test.go:
:
cmd := testutil.FakeCommand(c, "shutdown", "", true) :
However, in daemon_test.go, the code is currently relying on the service manager, provided by the overlord, to start the reaper. This is not a safe solution as not all test implementations may actually run the real overlord code, and even if they do, we have a potential race condition.
daemon.Init() -> overlord.New() -> servstate.NewManager() -> reaper.Start()
The following changes are introduced:
Add reaper.Start() and reaper.Stop() to the daemon test setup and teardown.
Add a reaper based test for testutil.FakeCommand().