Commits on Aug 1, 2023

1. daemon: FakeCommand usage requires reaper.Start() …

   The usage of testutil.FakeCommand requires the test environment to start
   and stop the reaper in the case where the reaper option is enabled.
   
   For example, in internals/daemon/daemon_test.go:
   
   :
   cmd := testutil.FakeCommand(c, "shutdown", "", true)
   :
   
   However, in daemon_test.go, the code is currently relying on the service
   manager, provided by the overlord, to start the reaper. This is not a
   safe solution as not all test implementations may actually run the real
   overlord code, and even if they do, we have a potential race condition.
   
   daemon.Init() -> overlord.New() -> servstate.NewManager() -> reaper.Start()
   
   The following changes are introduced:
   
   - Add reaper.Start() and reaper.Stop() to the daemon test setup and teardown.
   
   - Add a reaper based test for testutil.FakeCommand().

   

   flotter committed Aug 1, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 374389a
   • Browse repository at this point

   Copy the full SHA

   374389a View commit details

   Browse the repository at this point in the history