-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Rename SD-Core charms by adding -k8s as a suffix #57
Conversation
Signed-off-by: gatici <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a bit more to this one and any other one that publishes libs. You will need to register the charm and create a new lib because the existing lib is registered under the old charm name.
Signed-off-by: gatici <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good to me, but there's still the other part (registration and publishing) mentioned by @gruyaume
a9289a2
to
b317019
Compare
b317019
to
ed7e984
Compare
Signed-off-by: gatici <[email protected]>
ed7e984
to
e274af5
Compare
7679e20
to
751da46
Compare
The next protobuf version 4.21.0 has the breaking changes with the existing code https://protobuf.dev/news/2022-05-06/#python-updates Signed-off-by: gatici <[email protected]>
751da46
to
49fccb0
Compare
Description
Add -k8s as a suffix in both github and Charmhub name to follow TE042 .
- The next protobuf version 4.21.0 has the breaking changes with the existing code
- https://protobuf.dev/news/2022-05-06/#python-updates
Checklist: