Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(enrich): replace manual AST traversal with ASTVisitor from graphql-js #139

Merged
merged 54 commits into from
Jan 5, 2024
Merged

refactor(enrich): replace manual AST traversal with ASTVisitor from graphql-js #139

merged 54 commits into from
Jan 5, 2024

Conversation

schwma
Copy link
Member

@schwma schwma commented Nov 28, 2023

No description provided.

@schwma
WIP: Replace AST traversal with ASTVisitor
19dfa84
@schwma
WIP: literal parsing
3b9ba39
@schwma
Add WIP comments
bc07760
@schwma
Merge branch 'main' into ASTVisitor
3ff1c53
@schwma
WIP visitWithTypeInfo
d27d7f7
@schwma
WIP
38ee532
@schwma
WIP get types for scalar input literals
b580262
@schwma
Cleanup
7f74758
@schwma
Fix parsing of top level argument literal values
78fae20
@schwma
Remove unneeded top level if-statement
973631f
@schwma
Rename variable and argument
e86ad0b
@schwma
Rename _directPath -> _simplifiedPath
dbd886c
@schwma
Add comments for function that finds type
cb2b442
@schwma
Add comments explaining enriching of AST
8000d0b
@schwma
Remove skipParsing flag from substituted variable values
9fe16c0
@schwma
Improve comment and reorder properties
c18ec08
@schwma
Add enrich tests for each ASTVisitor action
2d0bd87
@schwma
Fix substitution of fragments with multiple top level selections
ab7058b
@schwma
Remove meta module
1c72c16
@schwma
Explain why SelectionSet visitor is used to substitute fragments
0c5e96b
@schwma
Extract literal parsing to own module
2593718
@schwma
Remove unneeded array wrapping
6d86847
@schwma
Shorter function
ef14b58
@schwma
Export fragment function directly
049a572
@schwma
Shorter kind checks
f35bf32
@schwma
Shorter if-statement returns
08e83a4
@schwma
Remove unneded if-statement
575d4b0
@schwma
Add comment about skipping parsing for variable values
e3c3b8a
@schwma
Wording in comment visitor -> visitor functions
27c94ad
@schwma
No longer deep clone field nodes
bfb21d4
@schwma schwma requested a review from a team as a code owner November 28, 2023 14:44
BobdenOs
BobdenOs reviewed Dec 1, 2023
View reviewed changes
lib/resolvers/parse/ast/literal.js Outdated Show resolved Hide resolved
lib/resolvers/parse/ast/literal.js Outdated Show resolved Hide resolved
@schwma schwma requested a review from BobdenOs December 1, 2023 14:57
BobdenOs
BobdenOs approved these changes Dec 4, 2023
View reviewed changes
lib/resolvers/parse/ast/literal.js Outdated Show resolved Hide resolved
@schwma schwma merged commit c92fa15 into main Jan 5, 2024
3 checks passed
@schwma schwma deleted the ASTVisitor branch January 5, 2024 11:58
@schwma schwma mentioned this pull request Jan 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BobdenOs BobdenOs BobdenOs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schwma @BobdenOs