Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(enrich): replace manual AST traversal with ASTVisitor from graphql-js #139

Merged
merged 54 commits into from
Jan 5, 2024
Merged
Changes from 1 commit
Commits
Show all changes
54 commits
Select commit Hold shift + click to select a range
19dfa84
WIP: Replace AST traversal with `ASTVisitor`
schwma Aug 25, 2023
3b9ba39
WIP: literal parsing
schwma Aug 25, 2023
bc07760
Add WIP comments
schwma Aug 25, 2023
3ff1c53
Merge branch 'main' into ASTVisitor
schwma Sep 21, 2023
d27d7f7
WIP visitWithTypeInfo
schwma Sep 21, 2023
38ee532
WIP
schwma Sep 21, 2023
b580262
WIP get types for scalar input literals
schwma Sep 21, 2023
7f74758
Cleanup
schwma Sep 21, 2023
78fae20
Fix parsing of top level argument literal values
schwma Sep 21, 2023
973631f
Remove unneeded top level if-statement
schwma Sep 22, 2023
e86ad0b
Rename variable and argument
schwma Sep 22, 2023
dbd886c
Rename `_directPath` -> `_simplifiedPath`
schwma Sep 22, 2023
cb2b442
Add comments for function that finds type
schwma Sep 22, 2023
8000d0b
Add comments explaining enriching of AST
schwma Sep 22, 2023
9fe16c0
Remove `skipParsing` flag from substituted variable values
schwma Sep 22, 2023
c18ec08
Improve comment and reorder properties
schwma Sep 22, 2023
2d0bd87
Add enrich tests for each ASTVisitor action
schwma Sep 22, 2023
ab7058b
Fix substitution of fragments with multiple top level selections
schwma Sep 22, 2023
1c72c16
Remove meta module
schwma Sep 22, 2023
0c5e96b
Explain why SelectionSet visitor is used to substitute fragments
schwma Sep 22, 2023
2593718
Extract literal parsing to own module
schwma Sep 22, 2023
6d86847
Remove unneeded array wrapping
schwma Sep 22, 2023
ef14b58
Shorter function
schwma Sep 22, 2023
049a572
Export fragment function directly
schwma Sep 22, 2023
f35bf32
Shorter kind checks
schwma Sep 22, 2023
08e83a4
Shorter if-statement returns
schwma Sep 22, 2023
575d4b0
Remove unneded if-statement
schwma Sep 22, 2023
e3c3b8a
Add comment about skipping parsing for variable values
schwma Sep 22, 2023
27c94ad
Wording in comment visitor -> visitor functions
schwma Sep 22, 2023
bfb21d4
No longer deep clone field nodes
schwma Oct 18, 2023
5021f59
Slice datetime millis by index instead of regex
schwma Oct 18, 2023
f9224c6
Extract common variables
schwma Oct 18, 2023
4096349
Reorder tests
schwma Oct 18, 2023
6745205
Merge branch 'main' into ASTVisitor
schwma Oct 18, 2023
d537037
Prettier format
schwma Oct 18, 2023
e0c76f3
Improve comment
schwma Oct 18, 2023
b170ffd
Add newline
schwma Oct 18, 2023
73bfcf8
Improve comments about unparsed literals
schwma Oct 18, 2023
d15ce6e
Prefix unused arguments with underscores
schwma Oct 18, 2023
7e3f4e1
Use destructuring assignments
schwma Oct 18, 2023
ab5f872
Rename `editedAST` -> `enrichedAST`
schwma Oct 18, 2023
7a33f83
Merge branch 'main' into ASTVisitor
schwma Nov 21, 2023
5f7f394
Merge branch 'main' into ASTVisitor
schwma Nov 23, 2023
ccc9a76
Reorder function declarations
schwma Nov 23, 2023
a601999
Merge branch 'main' into ASTVisitor
schwma Nov 28, 2023
b3021cc
Create array of scalar kinds once vs per function call
schwma Dec 1, 2023
ecb411d
Create array of path kinds once vs per function call
schwma Dec 1, 2023
bc1858d
Fix simplified path filter
schwma Dec 1, 2023
22c4ded
Extract next path element to variable
schwma Dec 1, 2023
5fd3c65
Avoid recreating function
schwma Dec 6, 2023
2fa986b
Merge branch 'main' into ASTVisitor
schwma Dec 7, 2023
b5a9385
Merge branch 'main' into ASTVisitor
schwma Jan 5, 2024
5ae3356
No array methods to avoid needlessly copying the array
schwma Jan 5, 2024
739a241
Improve grammar in comment
schwma Jan 5, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into ASTVisitor
schwma committed Nov 23, 2023
commit 5f7f39418cf67e94765c832dd0999d25aa6a0d0e

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.