Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include addressType for accurate PSBT translation in SignMultisigTransaction #159

Merged

Conversation

chadchapnick
Copy link
Contributor

Adjust inherited DirectKeystoreInteractions to accept an addressType prop for accurate PSBT translation when invoked in SignMultisigTransaction.

Copy link

changeset-bot bot commented Dec 12, 2024

🦋 Changeset detected

Latest commit: 0f622f0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@caravan/wallets Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
caravan-coordinator ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 1:45pm

Copy link
Contributor

@bucko13 bucko13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@bucko13 bucko13 merged commit 3e4b783 into caravan-bitcoin:main Dec 12, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants