Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency flatpickr to v4.6.13 #14993

Merged
merged 15 commits into from
Feb 20, 2024
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 23, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
flatpickr (source) 4.6.9 -> 4.6.13 age adoption passing confidence

Release Notes

chmln/flatpickr (flatpickr)

v4.6.13

Compare Source

What's Changed

New Contributors

Full Changelog: flatpickr/flatpickr@v4.6.11...v4.6.13

v4.6.11

Compare Source

There was a bug with time selection since so much stuff got merged in.
New tests have been added to prevent this from happening again.

What's Changed

New Contributors

Full Changelog: flatpickr/flatpickr@v4.6.10...v4.6.11

v4.6.10

Compare Source

What's Changed

New Contributors

Full Changelog: flatpickr/flatpickr@v4.6.9...v4.6.10


Configuration

📅 Schedule: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Never, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner October 23, 2023 00:29
@netlify
Copy link

netlify bot commented Oct 23, 2023

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 7acd047
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/65d511eb0097760008602c22
😎 Deploy Preview https://deploy-preview-14993--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 23, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit a98662c
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6548ffab05bdab0008cae47e
😎 Deploy Preview https://deploy-preview-14993--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tay1orjones tay1orjones requested review from a team and thyhmdo and removed request for a team October 23, 2023 14:17
@tay1orjones
Copy link
Member

@thyhmdo this PR updates the core dependency for the DatePicker/calendar. Could you do a visual/functional review just to be sure we don't miss anything?

@thyhmdo
Copy link
Member

thyhmdo commented Oct 24, 2023

Please double check on me but seems like:

  • allowInput is not working when I typed in the input fiedl
  • closeOnSelect also is not working
  • maxDate and minDate seem unclear of what to type in. For example: "10/31/2023"?

@tw15egan
Copy link
Collaborator

The allowInput issue should be fixed via #14927, just updated the PR with the latest from main so we can check when it is redeployed.

@renovate
Copy link
Contributor Author

renovate bot commented Oct 24, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@tay1orjones
Copy link
Member

closeOnSelect also is not working

This is a legacy bug that doesn't work currently, we can ignore it within the scope of this PR, though we should fix it at some point in the future.

@tay1orjones tay1orjones requested review from tw15egan and guidari and removed request for andreancardona and tw15egan November 13, 2023 21:10
@guidari
Copy link
Contributor

guidari commented Nov 16, 2023

Hey @tay1orjones
I only created an issue for the closeOnSelect prop.
The other two are working as expected.
Here it is the allowInput fix: #14927

@tay1orjones
Copy link
Member

This update includes an improvement to the focus management, provided by flatpickr, regarding a range with two inputs. After choosing a start date, tabbing the end date input and choosing a date, then while the calendar is open press escape.

At this stage, previously, the calendar would close and the start date input would be focused. Instead, it now focuses the end date input after closing the calendar. I've updated the tests to reflect this improvement.

@tay1orjones tay1orjones added this pull request to the merge queue Feb 20, 2024
Merged via the queue into main with commit effcba6 Feb 20, 2024
20 checks passed
@tay1orjones tay1orjones deleted the renovate/flatpickr-4.x branch February 20, 2024 21:29
Copy link
Contributor

The content of this pull request will be made available as part of our next release. For the full schedule of upcoming releases, check out our Release Radar page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants