fix: revert the code to fix infinite loop on controlled multiselect #16793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tay1orjones
approved these changes
Jun 17, 2024
tay1orjones
added
status: one more review 👀
and removed
status: ready for review 👀
labels
alisonjoseph
approved these changes
Jun 17, 2024
Merged
via the queue into
carbon-design-system:main
with commit Jun 17, 2024
5080057
21 of 22 checks passed
This was referenced Jun 18, 2024
|
Hey there! v11.60.0 was just released that references this issue/PR. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes both #16469 and #16716
reverted changes from 2 merged PRs, #15818 and #16139
Changelog
Changed
Removed
Testing / Reviewing
test the fluttering infinite loop effect and make sure it does not appear.