-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix : Prevents exceeding maxCount word limit in TextAera #16893
Merged
guidari
merged 7 commits into
carbon-design-system:main
from
2nikhiltom:fix_maxCount_words_bug
Jul 1, 2024
Merged
Fix : Prevents exceeding maxCount word limit in TextAera #16893
guidari
merged 7 commits into
carbon-design-system:main
from
2nikhiltom:fix_maxCount_words_bug
Jul 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
alisonjoseph
approved these changes
Jun 28, 2024
Gururajj77
approved these changes
Jul 1, 2024
guidari
approved these changes
Jul 1, 2024
Merged
via the queue into
carbon-design-system:main
with commit Jul 1, 2024
e05f46e
22 checks passed
Hey there! v11.61.0 was just released that references this issue/PR. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16892
When the maxCount word limit is set along with enableCounter prop , users can bypass this limit by pressing the Enter key, allowing them to enter more words than specified in the next/new line.
This PR will not allow users to press Enter key once the max word limit is reached (like how space key is stoped)
Changelog
New
Adds a new condition for Enter key on
onKeyDown
functionTesting / Reviewing
Open deploy preview
Visit TextArea -playground storybook
Enable
enableCounter
propSet
counterMode
toword
Set
maxCount
to 5Press
Enter
key and verify you should not be able to go to next line and type new words, and that word limit is not exceeded.