Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : Prevents exceeding maxCount word limit in TextAera #16893

Merged
merged 7 commits into from
Jul 1, 2024
Merged

Fix : Prevents exceeding maxCount word limit in TextAera #16893

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
041693e
fix(15337): fix release names in update automation
2nikhiltom Jun 17, 2024
275eb71
fix(15337): fix release names in update automation
2nikhiltom Jun 17, 2024
6def269
Merge branch 'carbon-design-system:main' into main
2nikhiltom Jun 20, 2024
ff5082b
Merge branch 'carbon-design-system:main' into main
2nikhiltom Jun 28, 2024
ee20e94
Merge branch 'main' of https://github.com/2nikhiltom/carbon
2nikhiltom Jun 28, 2024
e28036d
fix(16892): fix maxWordCount issue in textaera
2nikhiltom Jun 28, 2024
99858d4
Merge branch 'main' into fix_maxCount_words_bug
guidari Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/react/src/components/TextArea/TextArea.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,10 @@ const TextArea = React.forwardRef((props: TextAreaProps, forwardRef) => {
if (!disabled && enableCounter && counterMode === 'word') {
const key = evt.which;

if (maxCount && textCount >= maxCount && key === 32) {
if (
(maxCount && textCount >= maxCount && key === 32) ||
(maxCount && textCount >= maxCount && key === 13)
) {
evt.preventDefault();
}
}
Expand Down Expand Up @@ -424,6 +427,7 @@ const TextArea = React.forwardRef((props: TextAreaProps, forwardRef) => {
{...other}
{...textareaProps}
placeholder={placeholder}
aria-readonly={other.readOnly ? true : false}
className={textareaClasses}
aria-invalid={invalid}
aria-describedby={ariaDescribedBy}
Expand Down
Loading