Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tabs): contained layer tokens #17215

Conversation

ariellalgilmore
Copy link
Member

@ariellalgilmore ariellalgilmore commented Aug 19, 2024

Closes #17096

Tabs contained styles causing issues with Layer components already nested inside

Changelog

Changed

  • removed the force of Layer styles inside the contained styles
  • updated the Stories to show that when using field components inside a Contained Tab components should be wrapped in a Layer

Testing / Reviewing

Viewed on storybook

Copy link

netlify bot commented Aug 19, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6a977a8
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66c3a76fe624690008eabc47
😎 Deploy Preview https://deploy-preview-17215--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 19, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 920359e
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66c748ba4360dd00083e4863
😎 Deploy Preview https://deploy-preview-17215--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 19, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 920359e
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66c748bae01e0b0008007585
😎 Deploy Preview https://deploy-preview-17215--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@ariellalgilmore ariellalgilmore added this pull request to the merge queue Aug 22, 2024
Merged via the queue into carbon-design-system:main with commit a773f2e Aug 22, 2024
22 checks passed
@ariellalgilmore ariellalgilmore deleted the fix/tabs-contained-layer-styles branch August 22, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Tab CSS breaks backwards compatibility and multiple usages of Layer component
3 participants