Add a test for the case that impl function is poisoned
#4950
+157
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds missing coverage. Part of carbon-language#4622.
zygoloid
reviewed
Feb 15, 2025
Comment on lines
23
to
28
| class C2 { | ||
| // CHECK:STDERR: fail_impl_function_poisoned.carbon:[[@LINE+3]]:14: error: name used before it was declared [NameUseBeforeDecl] | ||
| // CHECK:STDERR: var v: F; | ||
| // CHECK:STDERR: ^ | ||
| var v: F; | ||
| } |
There was a problem hiding this comment.
It's probably best to use an example here that would otherwise be valid if possible, and it's not valid to declare things in the impl that don't correspond to names in the interface. How about something like this:
interface I {
fn A(x: Self);
fn B();
}
class B {
impl as I {
fn A(x: B);
fn B();
}
}Longer term, I think the plan is for name lookup for the impl scope to look in the facet (B as I in this case), so it would find the function name B from the interface here instead of the class name. It's invalid either way, though, and seems good to test.
There was a problem hiding this comment.
Done.
Interestingly, because B is poisoned, we also get ImplMissingFunction error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds missing coverage.
Part of #4622.