-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a test for the case that impl function is poisoned
#4950
Open
bricknerb
wants to merge
4
commits into
carbon-language:trunk
Choose a base branch
from
bricknerb:loc2
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+157
−0
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
3b99d44
Add a test for the case that `impl` function is poisoned
bricknerb c691b3b
Change the test to pass in case the class and function name wouldn't …
bricknerb 6a20873
Merge branch 'main' into loc2
bricknerb 89c2e66
Update test following changes upstream
bricknerb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
157 changes: 157 additions & 0 deletions
157
toolchain/check/testdata/impl/no_prelude/name_poisoning.carbon
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,157 @@ | ||
| // Part of the Carbon Language project, under the Apache License v2.0 with LLVM | ||
| // Exceptions. See /LICENSE for license information. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
| // | ||
| // AUTOUPDATE | ||
| // TIP: To test this file alone, run: | ||
| // TIP: bazel test //toolchain/testing:file_test --test_arg=--file_tests=toolchain/check/testdata/impl/no_prelude/name_poisoning.carbon | ||
| // TIP: To dump output, run: | ||
| // TIP: bazel run //toolchain/testing:file_test -- --dump_output --file_tests=toolchain/check/testdata/impl/no_prelude/name_poisoning.carbon | ||
|
|
||
| // --- fail_impl_function_poisoned.carbon | ||
|
|
||
| library "[[@TEST_NAME]]"; | ||
|
|
||
| interface I { | ||
| fn A(x: Self); | ||
| fn B(); | ||
| } | ||
|
|
||
| class B { | ||
| impl as I { | ||
| // CHECK:STDERR: fail_impl_function_poisoned.carbon:[[@LINE+3]]:13: error: name `B` used before it was declared [NameUseBeforeDecl] | ||
| // CHECK:STDERR: fn A(x: B); | ||
| // CHECK:STDERR: ^ | ||
| fn A(x: B); | ||
| // CHECK:STDERR: fail_impl_function_poisoned.carbon:[[@LINE+11]]:8: note: declared here [NameUseBeforeDeclNote] | ||
| // CHECK:STDERR: fn B(); | ||
| // CHECK:STDERR: ^ | ||
| // CHECK:STDERR: | ||
| // CHECK:STDERR: fail_impl_function_poisoned.carbon:[[@LINE-9]]:3: error: missing implementation of B in impl of interface I [ImplMissingFunction] | ||
| // CHECK:STDERR: impl as I { | ||
| // CHECK:STDERR: ^~~~~~~~~~~ | ||
| // CHECK:STDERR: fail_impl_function_poisoned.carbon:[[@LINE-16]]:3: note: associated function B declared here [AssociatedFunctionHere] | ||
| // CHECK:STDERR: fn B(); | ||
| // CHECK:STDERR: ^~~~~~~ | ||
| // CHECK:STDERR: | ||
| fn B(); | ||
| } | ||
| } | ||
|
|
||
| // CHECK:STDOUT: --- fail_impl_function_poisoned.carbon | ||
| // CHECK:STDOUT: | ||
| // CHECK:STDOUT: constants { | ||
| // CHECK:STDOUT: %I.type: type = facet_type <@I> [concrete] | ||
| // CHECK:STDOUT: %Self: %I.type = bind_symbolic_name Self, 0 [symbolic] | ||
| // CHECK:STDOUT: %Self.as_type: type = facet_access_type %Self [symbolic] | ||
| // CHECK:STDOUT: %A.type.edf: type = fn_type @A.1 [concrete] | ||
| // CHECK:STDOUT: %A.ab0: %A.type.edf = struct_value () [concrete] | ||
| // CHECK:STDOUT: %I.assoc_type: type = assoc_entity_type %I.type [concrete] | ||
| // CHECK:STDOUT: %assoc0: %I.assoc_type = assoc_entity element0, @I.%A.decl [concrete] | ||
| // CHECK:STDOUT: %B.type.785: type = fn_type @B.1 [concrete] | ||
| // CHECK:STDOUT: %B.6d4: %B.type.785 = struct_value () [concrete] | ||
| // CHECK:STDOUT: %assoc1: %I.assoc_type = assoc_entity element1, @I.%B.decl [concrete] | ||
| // CHECK:STDOUT: %B.fa3: type = class_type @B.3 [concrete] | ||
| // CHECK:STDOUT: %impl_witness: <witness> = impl_witness (@impl.%A.decl, <error>) [concrete] | ||
| // CHECK:STDOUT: %A.type.9b9: type = fn_type @A.2 [concrete] | ||
| // CHECK:STDOUT: %A.71f: %A.type.9b9 = struct_value () [concrete] | ||
| // CHECK:STDOUT: %B.type.52d: type = fn_type @B.2 [concrete] | ||
| // CHECK:STDOUT: %B.30a: %B.type.52d = struct_value () [concrete] | ||
| // CHECK:STDOUT: %I.facet: %I.type = facet_value %B.fa3, %impl_witness [concrete] | ||
| // CHECK:STDOUT: %empty_struct_type: type = struct_type {} [concrete] | ||
| // CHECK:STDOUT: %complete_type: <witness> = complete_type_witness %empty_struct_type [concrete] | ||
| // CHECK:STDOUT: } | ||
| // CHECK:STDOUT: | ||
| // CHECK:STDOUT: file { | ||
| // CHECK:STDOUT: package: <namespace> = namespace [concrete] { | ||
| // CHECK:STDOUT: .I = %I.decl | ||
| // CHECK:STDOUT: .B = %B.decl | ||
| // CHECK:STDOUT: } | ||
| // CHECK:STDOUT: %I.decl: type = interface_decl @I [concrete = constants.%I.type] {} {} | ||
| // CHECK:STDOUT: %B.decl: type = class_decl @B.3 [concrete = constants.%B.fa3] {} {} | ||
| // CHECK:STDOUT: } | ||
| // CHECK:STDOUT: | ||
| // CHECK:STDOUT: interface @I { | ||
| // CHECK:STDOUT: %Self: %I.type = bind_symbolic_name Self, 0 [symbolic = constants.%Self] | ||
| // CHECK:STDOUT: %A.decl: %A.type.edf = fn_decl @A.1 [concrete = constants.%A.ab0] { | ||
| // CHECK:STDOUT: %x.patt: @A.1.%Self.as_type.loc5_11.1 (%Self.as_type) = binding_pattern x | ||
| // CHECK:STDOUT: %x.param_patt: @A.1.%Self.as_type.loc5_11.1 (%Self.as_type) = value_param_pattern %x.patt, runtime_param0 | ||
| // CHECK:STDOUT: } { | ||
| // CHECK:STDOUT: %x.param: @A.1.%Self.as_type.loc5_11.1 (%Self.as_type) = value_param runtime_param0 | ||
| // CHECK:STDOUT: %.loc5_11.1: type = splice_block %.loc5_11.2 [symbolic = %Self.as_type.loc5_11.1 (constants.%Self.as_type)] { | ||
| // CHECK:STDOUT: %Self.ref: %I.type = name_ref Self, @I.%Self [symbolic = %Self (constants.%Self)] | ||
| // CHECK:STDOUT: %Self.as_type.loc5_11.2: type = facet_access_type %Self.ref [symbolic = %Self.as_type.loc5_11.1 (constants.%Self.as_type)] | ||
| // CHECK:STDOUT: %.loc5_11.2: type = converted %Self.ref, %Self.as_type.loc5_11.2 [symbolic = %Self.as_type.loc5_11.1 (constants.%Self.as_type)] | ||
| // CHECK:STDOUT: } | ||
| // CHECK:STDOUT: %x: @A.1.%Self.as_type.loc5_11.1 (%Self.as_type) = bind_name x, %x.param | ||
| // CHECK:STDOUT: } | ||
| // CHECK:STDOUT: %assoc0: %I.assoc_type = assoc_entity element0, %A.decl [concrete = constants.%assoc0] | ||
| // CHECK:STDOUT: %B.decl: %B.type.785 = fn_decl @B.1 [concrete = constants.%B.6d4] {} {} | ||
| // CHECK:STDOUT: %assoc1: %I.assoc_type = assoc_entity element1, %B.decl [concrete = constants.%assoc1] | ||
| // CHECK:STDOUT: | ||
| // CHECK:STDOUT: !members: | ||
| // CHECK:STDOUT: .Self = %Self | ||
| // CHECK:STDOUT: .A = %assoc0 | ||
| // CHECK:STDOUT: .B = %assoc1 | ||
| // CHECK:STDOUT: witness = (%A.decl, %B.decl) | ||
| // CHECK:STDOUT: } | ||
| // CHECK:STDOUT: | ||
| // CHECK:STDOUT: impl @impl: %Self.ref as %I.ref { | ||
| // CHECK:STDOUT: %A.decl: %A.type.9b9 = fn_decl @A.2 [concrete = constants.%A.71f] { | ||
| // CHECK:STDOUT: %x.patt: %B.fa3 = binding_pattern x | ||
| // CHECK:STDOUT: %x.param_patt: %B.fa3 = value_param_pattern %x.patt, runtime_param0 | ||
| // CHECK:STDOUT: } { | ||
| // CHECK:STDOUT: %x.param: %B.fa3 = value_param runtime_param0 | ||
| // CHECK:STDOUT: %B.ref: type = name_ref B, file.%B.decl [concrete = constants.%B.fa3] | ||
| // CHECK:STDOUT: %x: %B.fa3 = bind_name x, %x.param | ||
| // CHECK:STDOUT: } | ||
| // CHECK:STDOUT: %B.decl: %B.type.52d = fn_decl @B.2 [concrete = constants.%B.30a] {} {} | ||
| // CHECK:STDOUT: | ||
| // CHECK:STDOUT: !members: | ||
| // CHECK:STDOUT: .B = <poisoned> | ||
| // CHECK:STDOUT: .A = %A.decl | ||
| // CHECK:STDOUT: witness = @B.3.%impl_witness | ||
| // CHECK:STDOUT: } | ||
| // CHECK:STDOUT: | ||
| // CHECK:STDOUT: class @B.3 { | ||
| // CHECK:STDOUT: impl_decl @impl [concrete] {} { | ||
| // CHECK:STDOUT: %Self.ref: type = name_ref Self, constants.%B.fa3 [concrete = constants.%B.fa3] | ||
| // CHECK:STDOUT: %I.ref: type = name_ref I, file.%I.decl [concrete = constants.%I.type] | ||
| // CHECK:STDOUT: } | ||
| // CHECK:STDOUT: %impl_witness: <witness> = impl_witness (@impl.%A.decl, <error>) [concrete = constants.%impl_witness] | ||
| // CHECK:STDOUT: %complete_type: <witness> = complete_type_witness %empty_struct_type [concrete = constants.%complete_type] | ||
| // CHECK:STDOUT: complete_type_witness = %complete_type | ||
| // CHECK:STDOUT: | ||
| // CHECK:STDOUT: !members: | ||
| // CHECK:STDOUT: .Self = constants.%B.fa3 | ||
| // CHECK:STDOUT: .I = <poisoned> | ||
| // CHECK:STDOUT: .B = <poisoned> | ||
| // CHECK:STDOUT: } | ||
| // CHECK:STDOUT: | ||
| // CHECK:STDOUT: generic fn @A.1(@I.%Self: %I.type) { | ||
| // CHECK:STDOUT: %Self: %I.type = bind_symbolic_name Self, 0 [symbolic = %Self (constants.%Self)] | ||
| // CHECK:STDOUT: %Self.as_type.loc5_11.1: type = facet_access_type %Self [symbolic = %Self.as_type.loc5_11.1 (constants.%Self.as_type)] | ||
| // CHECK:STDOUT: | ||
| // CHECK:STDOUT: fn(%x.param_patt: @A.1.%Self.as_type.loc5_11.1 (%Self.as_type)); | ||
| // CHECK:STDOUT: } | ||
| // CHECK:STDOUT: | ||
| // CHECK:STDOUT: generic fn @B.1(@I.%Self: %I.type) { | ||
| // CHECK:STDOUT: fn(); | ||
| // CHECK:STDOUT: } | ||
| // CHECK:STDOUT: | ||
| // CHECK:STDOUT: fn @A.2(%x.param_patt: %B.fa3); | ||
| // CHECK:STDOUT: | ||
| // CHECK:STDOUT: fn @B.2(); | ||
| // CHECK:STDOUT: | ||
| // CHECK:STDOUT: specific @A.1(constants.%Self) { | ||
| // CHECK:STDOUT: %Self => constants.%Self | ||
| // CHECK:STDOUT: %Self.as_type.loc5_11.1 => constants.%Self.as_type | ||
| // CHECK:STDOUT: } | ||
| // CHECK:STDOUT: | ||
| // CHECK:STDOUT: specific @B.1(constants.%Self) {} | ||
| // CHECK:STDOUT: | ||
| // CHECK:STDOUT: specific @A.1(constants.%I.facet) { | ||
| // CHECK:STDOUT: %Self => constants.%I.facet | ||
| // CHECK:STDOUT: %Self.as_type.loc5_11.1 => constants.%B.fa3 | ||
| // CHECK:STDOUT: } | ||
| // CHECK:STDOUT: | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This second diagnostic doesn't appear to be correct / useful; maybe we should include a TODO to not produce it?