Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix relative pose for sync mode #570

Conversation

KevinLADLee
Copy link
Contributor

@KevinLADLee KevinLADLee commented Sep 17, 2021

Fixes #559 .


This change is Reviewable

Copy link

@lasuomela lasuomela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @KevinLADLee)

Copy link
Contributor

@berndgassmann berndgassmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @KevinLADLee)


carla_ros_bridge/src/carla_ros_bridge/actor_factory.py, line 115 at r1 (raw file):

            carla_actor = self.world.get_actor(actor_id)
            if self.node.parameters["register_all_sensors"] or not isinstance(carla_actor, carla.Sensor):
                self._create_object_from_actor(carla_actor, None)

I guess you are spawning the vehicles via the ros-bridge. Did you also test your code when vehicles and sensors are spawned e.g. via manual_control? Because then, this code is called. In this case the TF will become wrong, because then you would at least have to keep the realative calculations in respect to the parent which you delete completely below.
I've just created a PR #571 that fixes the root-cause for the issue and give the CARLA server a tick before consuming the data.

@KevinLADLee
Copy link
Contributor Author

#571 fixes the root cause for the issue. Closed this pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sensor spawn at wrong position / in wrong tf
3 participants