-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate "variable" (Japanese) #297
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
eb05442
translate variable into Japanese
TomKellyGenetics c4ba0d1
change Japanese to dictionary form
TomKellyGenetics 8f5f12c
Apply suggestions from code review
TomKellyGenetics d41f0e2
Update Japanese definition of ‘variable’
TomKellyGenetics 0057b23
Remove English terms from Japanese definition for 'variable'
TomKellyGenetics File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand this sentence is specifically added for Japanese. If it should stay, I would suggest to modify:
変数は英語で「variable」(ヴァリアブル)という / 呼ぶ (whichever you prefer)。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about the scope of glosario but I've seen a lot of Japanese definitions give the English term, especially for technical jargon as Japanese users will likely encounter them in English documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw a conversation with @naoe-tatara at #303 (comment). I feel it may be easier to avoid mentioning a pronunciation in other languages for now. When Japanese is interested to know how to say a word in English, they should check with glosario en entry or Google. Let's keep each entry simple.