Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOS attack from foreign and bad escrow #32

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Conversation

reednaa
Copy link
Member

@reednaa reednaa commented Mar 12, 2024

No description provided.

@reednaa reednaa requested a review from jsanmigimeno March 12, 2024 16:13
Copy link
Member

@jsanmigimeno jsanmigimeno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@reednaa
Copy link
Member Author

reednaa commented Mar 20, 2024

I noticed that this protection wasn't enough. I added the source identifier to the check and changed the scheme. Please review and consider if this would replace the migration in #38

@reednaa reednaa requested a review from jsanmigimeno March 20, 2024 10:25
@reednaa reednaa mentioned this pull request Mar 20, 2024
@reednaa reednaa merged commit 8cdb821 into main Apr 2, 2024
1 check passed
@reednaa reednaa deleted the dos-messageidentifier branch April 2, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants