distro: add eject FreeBSD code path #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Azure currently relies on eject for some use cases. In noble minimal images eject is not installed by default. This change prefers a udev command that performs the same action before trying eject. A integration test has been created but is not functional. Code changes have not been tested. [1] canonical#4732 Co-authored-by: James Falcon <[email protected]>
In response to Brett's suggestion that we explicitly try eject options rather than making assumptions about systemd. Keeping this as a separate commit so we can see the options.
OpenBSD, NetBSD, and Dragonfly all have an eject(1), so they should be covered in the default code path. FreeBSD however, does not have eject in base. It's an (unmaintained) port. In base, we do however, have camcontrol(8) and cdcontrol(1), both of which have an eject subcommand. Let's use camcontrol(8) here. Sponsored by: The FreeBSD Foundation
catmsred
force-pushed
the
fix_eject
branch
2 times, most recently
from
32f5a5c
to
64cd741
Compare
5 tasks
|
Hey @igalic, I'd rather merge the other one first and then rebase this one against main, just to keep reviews small and less complicated. Does that work for you? |
|
@igalic , feel free to re-open this one against cloud-init main now! |
|
here it is canonical#4838 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenBSD, NetBSD, and Dragonfly all have an eject(1), so they should be covered in the default code path.
FreeBSD however, does not have eject in base. It's an (unmaintained) port. In base, we do however, have camcontrol(8) and cdcontrol(1), both of which have an eject subcommand.
Let's use camcontrol(8) here.
Sponsored by: The FreeBSD Foundation