Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

distro: add eject FreeBSD code path #1

Closed
wants to merge 3 commits into from
Closed

distro: add eject FreeBSD code path #1

wants to merge 3 commits into from

Commits on Jan 30, 2024

  1. feat: prefer udev's cdrom_id -e to eject 

    Azure currently relies on eject for some use cases.  In noble
minimal images eject is not installed by default.  This change
prefers a udev command that performs the same action before
trying eject.

A integration test has been created but is not functional.  Code
changes have not been tested.

[1] canonical#4732

Co-authored-by: James Falcon <[email protected]>
    @catmsred @TheRealFalcon
    catmsred and TheRealFalcon committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    7e2face View commit details
    Browse the repository at this point in the history

  2. To be squashed 

    In response to Brett's suggestion that we explicitly try eject
options rather than making assumptions about systemd.  Keeping
this as a separate commit so we can see the options.
    @catmsred
    catmsred committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    7dbb858 View commit details
    Browse the repository at this point in the history

  3. distro: add eject FreeBSD code path 

    OpenBSD, NetBSD, and Dragonfly all have an eject(1), so they should be
covered in the default code path.

FreeBSD however, does not have eject in base. It's an (unmaintained)
port. In base, we do however, have camcontrol(8) and cdcontrol(1), both
of which have an eject subcommand.

Let's use camcontrol(8) here.

Sponsored by: The FreeBSD Foundation
    @igalic
    igalic committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    8ce15f7 View commit details
    Browse the repository at this point in the history