Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add experiment with modelling failing communication channels #119

Merged
merged 8 commits into from
Sep 19, 2023
Merged

Add experiment with modelling failing communication channels #119

merged 8 commits into from
Sep 19, 2023

Conversation

pawel-czyz
Copy link
Member

@pawel-czyz pawel-czyz commented Sep 16, 2023 •
edited
Loading

This PR turned out to be trickier and larger than expected. Anyway, here it goes with the following changes:

  • We now use auxiliary workflow for our typical benchmark rules. Note that it now scales tasks automatically, so that UNSCALED_TASKS should be declared rather than TASKS. In particular, look how much cool_tasks.smk has shrunk.
  • It adds a product distribution (for independent random variables) to the fine subpackage. It also adds to the public API utilities for creating TensorFlow Probability's multivariate normal and Student distributions. (Which were previously hidden).
  • It adds the workflow for studying outliers/failing communication channels. It's ugly, but it seems that it does the job.

If you think it's ready to be merged, please merge – I will have little coding time until Wednesday evening...

@pawel-czyz pawel-czyz added 🚂 type: enhancement New feature or request 🧪 type: experiment Used for experiments and proof of concepts labels Sep 16, 2023
@pawel-czyz pawel-czyz marked this pull request as ready for review September 17, 2023 09:29
grfrederic
grfrederic approved these changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@grfrederic grfrederic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm very glad we decided to go with snakemake in the end :)

@grfrederic grfrederic merged commit 21dbdca into main Sep 19, 2023
2 checks passed
@grfrederic grfrederic deleted the pawel/outliers branch September 19, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grfrederic grfrederic grfrederic approved these changes

Assignees
No one assigned
Labels
🚂 type: enhancement New feature or request 🧪 type: experiment Used for experiments and proof of concepts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pawel-czyz @grfrederic