Refactor the JAX utilities for the multinomial model #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawel-czyz
added
enhancement
pawel-czyz
changed the title
dr-david
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi David,
I think it's the right moment to do some convenient refactoring changes, redesigning the API.
I propose to do the following:
_quasimultinomial.py, as it'll better fit.CityDataobject from the public API. I think this wrapper should be deprecated in favour of directly specifying the timepoints and observed proportions (as well as easier specification of quasimultinomial sample sizenand the overdispersion factors).construct_total_loss, so that it's compatible with the new API.construct_model, which returns a convenient to sample NumPyro model.