Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: rust bind silo-input-transformer in docker #51

Merged
merged 33 commits into from
Dec 2, 2024

Conversation

gordonkoehn
Copy link
Collaborator

Integrating the silo-input-transformer.

@gordonkoehn gordonkoehn added enhancement New feature or request help wanted Extra attention is needed dependencies Pull requests that update a dependency file labels Nov 26, 2024
@gordonkoehn gordonkoehn self-assigned this Nov 26, 2024
@gordonkoehn gordonkoehn linked an issue Nov 26, 2024 that may be closed by this pull request
@gordonkoehn
Copy link
Collaborator Author

I've never bound rust to python but a quick search leads me to PyO3. Let's try this..

@gordonkoehn
Copy link
Collaborator Author

Alright, here is what I did so far.

I decided that as silo_input_transformer is a small utility it should be handled as a dependency so let's not make a separate docker, which would been handling filed between dockers in the docker compose, but rather bind the rust to the python. There seems to be plenty of ways to do this.

And I did it using pyo3.

I can now run the Rust project from python :)

The code from Fabian is currently added as a git subdirectory. We yet of of course this does not work online or in the github action as the directory is still private.

@gordonkoehn gordonkoehn linked an issue Nov 29, 2024 that may be closed by this pull request
@gordonkoehn gordonkoehn marked this pull request as ready for review December 2, 2024 10:28
@gordonkoehn gordonkoehn requested a review from Copilot December 2, 2024 10:28

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 12 out of 12 changed files in this pull request and generated no suggestions.

@gordonkoehn
Copy link
Collaborator Author

this gitsubmoduel stufff does not work with test and all.

It does not matter if this is public or not so let's just commit it for now

@gordonkoehn gordonkoehn changed the title feature: rust bind silo-input-transformer as git submodule in docker feature: rust bind silo-input-transformer in docker Dec 2, 2024
@gordonkoehn gordonkoehn merged commit 4f3efe1 into main Dec 2, 2024
2 checks passed
@gordonkoehn gordonkoehn deleted the feature/add_silo_input_trafo branch December 2, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bind silo-input-transformer into sr2silo transform to ndjson
1 participant