Treat HP campaign args same as HP discount args #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shengy90
reviewed
Dec 2, 2024
shengy90
reviewed
Dec 2, 2024
simulation/__main__.py
Outdated
| f"Campaign target awareness must be greater than or equal to the population heat pump awareness, got campaign_target_heat_pump_awareness:{args.campaign_target_heat_pump_awareness}, heat_pump_awareness:{args.heat_pump_awareness}" | ||
| if args.campaign_target_heat_pump_awareness_date is not None: | ||
| # Check that target awareness inputs increase over the model horizon | ||
| campaigns = sorted(args.campaign_target_heat_pump_awareness_date) |
There was a problem hiding this comment.
This should be a function that we unit test I think!
There was a problem hiding this comment.
See test_campaign_target_less_than_heat_pump_awareness_raises_value_error in test_main
There was a problem hiding this comment.
Oh I mean the logic inside this if statement - it's a pretty convoluted logic that I think we should write as a function, then test that given inputs you get expected output.
e.g.
if args.campaign_target_heat_pump_awareness_date is not None:
x = parse_campaign_dates_and_target(arg1, arg2)
# in test_main.py
def test_parse_campaign_dates_and_target():
test this function.Increase maintainability of the code - if someone changes some stuff then this test will break, and they'd have to either update the tests (if break is intended) or fix the change to conform to the test etc.
shengy90
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run ABM with HP awareness starting at 25%, increasing to 50% at 2030 and 75% by 2034. To achieve this, allow for user to run ABM with multiple inputs for the HP awareness campaign similar to the inputs for HP discount args.
Update grant caps for BUS.